CodeGen v2: Finish polymorphic inheritance support #213
Conversation
ajor
force-pushed
the
type-graph-polymorphic-inheritance
branch
from
6607008 to
79b045e
Compare
ajor
force-pushed
the
type-graph-polymorphic-inheritance
branch
from
79b045e to
be562f5
Compare
|
Hi @ajor! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This is currently broken because the Class-IDs generated by CodeGen v1 and CodeGen v2 do not match, and TreeBuilder only understands CodeGen v1's IDs.
CodeGen v2 fixes a number of issues with the polymorphic inheritance support, however, so I don't want to force it into using the old IDs.
TODO: Add tests for polymorphic inheritance with namespaces - this was broken in v1 but should work now